Skip to content

ci: refactor some workflows to make tests properly run on main#3074

Merged
anakin87 merged 1 commit intomainfrom
make-tests-run-main
Apr 1, 2026
Merged

ci: refactor some workflows to make tests properly run on main#3074
anakin87 merged 1 commit intomainfrom
make-tests-run-main

Conversation

@anakin87
Copy link
Copy Markdown
Member

@anakin87 anakin87 commented Apr 1, 2026

Related Issues

We now need tests running on main to compute combined tests coverage.
Some workflows are not running correctly.

Proposed Changes:

  • Pinecone: manually build the test matrix which is complex
  • llama.cpp: here we got permission denied when downloading models. This likely happens because the coverage action writes some files with root permissions. I'm now trying to fix this by downloading models to the cache dir, that should not be touched by the coverage action.

How did you test it?

CI but since failures happened on main, we should merge to actually test

Checklist

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 1, 2026

Coverage report (pinecone)

This PR does not seem to contain any modification to coverable code.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 1, 2026

Coverage report (langfuse)

This PR does not seem to contain any modification to coverable code.

@anakin87 anakin87 marked this pull request as ready for review April 1, 2026 07:44
@anakin87 anakin87 requested a review from a team as a code owner April 1, 2026 07:44
@anakin87 anakin87 requested review from davidsbatista and removed request for a team April 1, 2026 07:44
@anakin87 anakin87 self-assigned this Apr 1, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 1, 2026

Coverage report (llama_cpp)

This PR does not seem to contain any modification to coverable code.

@anakin87 anakin87 merged commit 0f5756b into main Apr 1, 2026
24 checks passed
@anakin87 anakin87 deleted the make-tests-run-main branch April 1, 2026 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants